feat: Add TypeScript type definitions#696
Merged
mjeanroy merged 1 commit intomjeanroy:masterfrom Sep 19, 2021
pastelmind:feat-type-definitions
Merged
feat: Add TypeScript type definitions#696mjeanroy merged 1 commit intomjeanroy:masterfrom pastelmind:feat-type-definitions
mjeanroy merged 1 commit intomjeanroy:masterfrom
pastelmind:feat-type-definitions
Conversation
Also add @types/prettier as dependency.
Owner
|
Thanks @pastelmind (and so sorry for the delay)! |
Owner
|
@pastelmind Version 2.2.0 has just been published, thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds TypeScript type definitions for rollup-plugin-prettier. This enables downstream projects that want to type-check their Rollup config files to use rollup-plugin-prettier.
Hello! Thanks for creating rollup-plugin-prettier. Many people including myself want to use TypeScript to type-check their Rollup config files. Providing a type definition not only ensures type safety, but enables code editors (e.g. VS Code) to provide better code suggestions and hints when editing the config file, which significantly improves developer productivity. Thus, I'd like to request adding a type definition file (
index.d.ts) for rollup-plugin-prettier.This PR also adds @types/prettier as dependency. This is needed because rollup-plugin-prettier accepts the same config options used by Prettier.