Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #120 +/- ##
==========================================
+ Coverage 80.37% 80.46% +0.09%
==========================================
Files 13 13
Lines 5777 5799 +22
==========================================
+ Hits 4643 4666 +23
+ Misses 1134 1133 -1
☔ View full report in Codecov by Sentry. |
|
Tests of nested vlen types are only successful for NetCDF versions 4.9.0 and later, which include PR Unidata/netcdf-c#2179. To ensure that tests succeed on all supported versions of NetCDF (from 4.1.3 upwards), we avoid testing nested vlen types on NetCDF versions less than 4.9.0 (see d7b17f5). |
|
Tests of vlen with fill value (other than nested vlen types) were successful with NetCDF versions 4.1.3, 4.8.0, 4.9.0 and 4.9.2. The tests also worked successfully with |
|
Running the tests with both |
This PR adds support for fill values in vlen types when
na.mode=5is set forvar.put.ncorvar.get.nc.The
_FillValueattribute is required to have the same vlen type as the variable, and it must contain only a single vlen element. The first basetype value in the vlen element is used as the fill value. This is the approach used in the netcdf library, as described inUnidata/netcdf-c#1011 (comment) .