Added univariate streaming algorithms#9
Merged
Conversation
gloriadesideri
commented
Jul 30, 2025
gloriadesideri
commented
Contributor
- Used River library to implement AdWin, KsWin and Page Hinkley
- Added tests for the new algorithms
- Added empy dataset checks
GiovanniGiacometti
suggested changes
Jul 30, 2025
GiovanniGiacometti
left a comment
GiovanniGiacometti
left a comment
Contributor
There was a problem hiding this comment.
Some minor comments but overall looks great 🚀
GiovanniGiacometti
suggested changes
Jul 31, 2025
Contributor
|
LGTM - @alelavml3 any comments? |
alelavml3
requested changes
Jul 31, 2025
…ed multivariate edge case validation
alelavml3
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.