Conversation
mmschlk
added
feature 💡
mmschlk
deleted the
169-allow-for-importing-benchmark-functions-directly-from-modules-package
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up the games.benchmark module by separating the logic for conducting benchmarks (e.g. plotting, running benchmarks, configurations, ...) from the definitions of the benchmark games (e.g.
CaliforniaHousingLocalXAI,AdultCensusFeatureSelection, etc.). With this benchmark functions are more easily accessible and can be extended/varied without touching the game definitions.Without this refactoring, directly importing most of the functions is not possible because of circular imports.
This PR works on #169.