Adds BaselineImputer and Reworks MarginalImputer#262
Merged
Conversation
Closed
Advueu963
reviewed
Oct 29, 2024
Advueu963
approved these changes
Oct 29, 2024
Collaborator
Advueu963
left a comment
There was a problem hiding this comment.
Commented on some parameters, where the docs are missing.
Nice Code and great work!
Advueu963
reviewed
Oct 29, 2024
Advueu963
approved these changes
Oct 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR: This PR closes #261 and this PR closes #107.
This pull request introduces several updates to the
shapiqpackage, focusing on the addition of a newBaselineImputerclass and various improvements to existing imputer classes.New Features:
BaselineImputerclass for imputing missing values using predefined baseline values or calculated mean/mode from background data. (shapiq/games/imputer/baseline_imputer.py)Updates to Existing Features:
sample_replacementsparameter fromMarginalImputerand added ajoint_marginal_distributionparameter. A DeprecationWarning forsample_replacementshas been added. (shapiq/games/imputer/marginal_imputer.py)Imputerbase class by adding new attributes (n_features,data,model,sample_size) and methods (fit,xproperty) to improve flexibility and functionality. (shapiq/games/imputer/base.py)Codebase Organization:
__all__lists to include the newBaselineImputerclass. (shapiq/__init__.py,shapiq/games/__init__.py,shapiq/games/imputer/__init__.py)Documentation:
CHANGELOG.mdto reflect the new features and changes, including the addition ofBaselineImputerand the removal of thesample_replacementsparameter fromMarginalImputer.Minor Improvements:
shapiq/games/base.pyto consider removing a potentially runtime-increasing check. (shapiq/games/base.py)