Enhance type safety and fix bugs across the codebase#430
Merged
Conversation
Owner
|
This is crazy good! Wow thank you so much. Let's go through this together! |
…ctComputer can either exist or not, depending on dynamic Type
Removed the step to reinstall Python on Windows due to issues with tkinter. The linked GitHub issue was solved. Doing this as a first try.
Reinstall Python and install Tkinter for Windows tests. prior commit did not help
…plotlib usage for headless environments
mmschlk
approved these changes
Oct 14, 2025
github-project-automation
Bot
moved this from 👀 In review
to ✅ Done
in shapiq development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Being statically typed as a package is a very important desireta which this PR addresses.
It adds pyright to the .venv and adds it to of the pre-commit hooks.
The changes are quite extensive thus the integration must be done slowly and with a lot of discussions.
Public API Changes
How Has This Been Tested?
It has been tested locally running
pyrightin the top-level folder.Additionally it was added to pre-commit, making all future changes statically typed.
Checklist
CHANGELOG.md(if relevant for users).