Conversation
16 tasks
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
mmschlk
requested changes
Oct 24, 2025
Owner
mmschlk
left a comment
There was a problem hiding this comment.
Amazing work! Love the tests, love the code, it's simple and understandable! I had three nitpicks only regarding the model typings, since I think this might be easily approved.
mmschlk
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This pull request tackles #425 and introduces a new model-specific explanation method, the
ProductKernelExplainer, for product kernel-based machine learning models (such as Gaussian Processes and Support Vector Machines). The implementation includes new classes, conversion utilities, and kernel game logic, enabling exact computation of Shapley values for these models. Several supporting files and types are added, along with minor cleanups elsewhere in the codebase.The main work was done by @IsaH57.
New Product Kernel Explainer functionality:
ProductKernelExplainerclass for model-specific explanations of product kernel-based models, supporting exact Shapley value computation for regression and classification models. Currently, it is restricted to methods using the RBF kernel.ProductKernelComputerclass, including efficient Shapley value computation algorithms and kernel vector utilities.ProductKernelModeldataclass to standardise storage of kernel model parameters.ProductKernelGamefor evaluating the kernel-based cooperative game underlying the Shapley value computations.Public API Changes
We introduce a new Explainer, namely the
ProductKernelExplainer, giving efficient computation of Shapley Values for kernel-based machine learning models.How Has This Been Tested?
Unit and Integration Tests have been added to the test suite to ensure the correctness of the method.
Checklist
CHANGELOG.md(if relevant for users).