Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the v1.4.0 release with multiple improvements including documentation updates, removal of unused imports, and improved CI testing matrix. Key changes include:
- Improved docstrings for
GaussianImputerandGaussianCopulaImputerclasses with better formatting and clarity - Removed unused
typing_extensionsimports and@overridedecorators from imputer classes - Enhanced CI workflow to test across multiple Python versions (3.10, 3.12, 3.13) and operating systems (Ubuntu, Windows, macOS)
- Updated project metadata to add a new maintainer and author
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/shapiq/imputer/gaussian_imputer.py | Removed unused typing_extensions import and @override decorator; improved docstring formatting with better parameter descriptions |
| src/shapiq/imputer/gaussian_copula_imputer.py | Removed unused typing_extensions import and @override decorator; added comprehensive docstring for __init__ method |
| pyproject.toml | Added Santo M. A. R. Thies as author and maintainer |
| README.md | Reorganized ProxySPEX section to appear before visualizations section for better flow |
| CHANGELOG.md | Restructured and finalized v1.4.0 release notes with detailed sections for features, breaking changes, bugfixes, and maintenance |
| .github/workflows/ci.yml | Expanded CI testing matrix to include Python 3.10, 3.12, 3.13 across Ubuntu, Windows, and macOS; removed emoji from success messages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Makes the 1.4.0 release.
Public API Changes
How Has This Been Tested?
Checklist
CHANGELOG.md(if relevant for users).