Skip to content

Remove Outdated/Dead Code#514

Merged
Advueu963 merged 10 commits intomainfrom
remove-dead-code
Apr 21, 2026
Merged

Remove Outdated/Dead Code#514
Advueu963 merged 10 commits intomainfrom
remove-dead-code

Conversation

@mmschlk
Copy link
Copy Markdown
Owner

@mmschlk mmschlk commented Apr 21, 2026

Summary

  • Remove dead code: old benchmark scripts, deprecated redirects, outdated tree conversion utility
  • Remove legacy shapiq_games tests and CI workflow (package was split out)
  • Convert all 2042 precomputed game files from .npz to .json format and remove the conversion script

Motivation

General housekeeping — cleans up code and tests that no longer serve a purpose, and completes the long-overdue migration of precomputed game files to the JSON format used everywhere else in the project.

mmschlk added 8 commits April 21, 2026 14:11
Signed-off-by: Maximilian <maximilian.muschalik@gmail.com>
Signed-off-by: Maximilian <maximilian.muschalik@gmail.com>
Signed-off-by: Maximilian <maximilian.muschalik@gmail.com>
Signed-off-by: Maximilian <maximilian.muschalik@gmail.com>
Signed-off-by: Maximilian <maximilian.muschalik@gmail.com>
Signed-off-by: Maximilian <maximilian.muschalik@gmail.com>
Signed-off-by: Maximilian <maximilian.muschalik@gmail.com>
Signed-off-by: Maximilian <maximilian.muschalik@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Signed-off-by: Maximilian <maximilian.muschalik@gmail.com>
@mmschlk mmschlk marked this pull request as ready for review April 21, 2026 15:10
@mmschlk mmschlk requested review from Advueu963 and Copilot and removed request for Copilot April 21, 2026 15:10
…d we will have a different implemenation in shapiq benchmark)

Signed-off-by: Maximilian <maximilian.muschalik@gmail.com>
@mmschlk mmschlk added this to the 1.5.0 milestone Apr 21, 2026
@mmschlk mmschlk self-assigned this Apr 21, 2026
Copy link
Copy Markdown
Collaborator

@Advueu963 Advueu963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Advueu963 Advueu963 merged commit 8f23fbd into main Apr 21, 2026
13 checks passed
@Advueu963 Advueu963 deleted the remove-dead-code branch April 21, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants