ci(docker): self-trigger on workflow file changes#1550
Merged
brunobuddy merged 1 commit intomainfrom Apr 13, 2026
Merged
Conversation
The path filter for pull_request didn't include the workflow file itself, so PRs that only touch .github/workflows/docker.yml (like the previous commit on this branch) don't exercise the Docker validate job. Add the workflow file to its own filter so changes self-validate.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1550 +/- ##
=======================================
Coverage 97.93% 97.93%
=======================================
Files 118 118
Lines 8581 8581
Branches 3230 3230
=======================================
Hits 8404 8404
Misses 175 175
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tiny follow-up to #1549. The Docker workflow's
pull_requestpath filter didn't include.github/workflows/docker.ymlitself, so PRs that only touch the workflow — like #1549 did — don't actually exercise the Dockervalidatejob. I only caught this after #1549 merged and realised the new amd64/arm64 matrix had never been run against a real PR.Adding the workflow file to its own path filter is standard practice and makes future workflow edits self-validate.
Test plan
Build (validate, amd64)andBuild (validate, arm64)in the checks — that's the first real signal that the native-runner matrix shape from ci(docker): build arm64 on native runners, drop QEMU emulation #1549 actually works. If either check fails, that's the signal to iterate on ci(docker): build arm64 on native runners, drop QEMU emulation #1549's shape.Summary by cubic
Include
.github/workflows/docker.ymlin the Docker workflow’spull_request.pathsso edits to the workflow trigger the Dockervalidatejob (amd64/arm64). This ensures workflow changes self-validate instead of silently skipping the matrix.Written for commit 06aef89. Summary will update on new commits.