fix(routing): prevent long model names from overflowing tier cards#1600
Merged
fix(routing): prevent long model names from overflowing tier cards#1600
Conversation
Long model names (e.g. custom provider UUIDs) were pushing tier cards beyond their grid column, breaking the 4-column layout. Add min-width: 0 on the chip containers so flex children can shrink and the existing text-overflow: ellipsis on .routing-card__main takes effect. Also fix provider icon vertical alignment (flex-start → center).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1600 +/- ##
=======================================
Coverage 98.01% 98.01%
=======================================
Files 119 119
Lines 8967 8967
Branches 3372 3372
=======================================
Hits 8789 8789
Misses 176 176
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/frontend/src/styles/routing.css">
<violation number="1" location="packages/frontend/src/styles/routing.css:142">
P2: `overflow: hidden` on `.routing-card` can clip chip tooltips that are absolutely positioned outside their trigger.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| border: 1px solid hsl(var(--border)); | ||
| border-radius: var(--radius); | ||
| min-height: 0; | ||
| overflow: hidden; |
There was a problem hiding this comment.
P2: overflow: hidden on .routing-card can clip chip tooltips that are absolutely positioned outside their trigger.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/frontend/src/styles/routing.css, line 142:
<comment>`overflow: hidden` on `.routing-card` can clip chip tooltips that are absolutely positioned outside their trigger.</comment>
<file context>
@@ -139,6 +139,7 @@
border: 1px solid hsl(var(--border));
border-radius: var(--radius);
min-height: 0;
+ overflow: hidden;
}
</file context>
Suggested change
| overflow: hidden; | |
| overflow: visible; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
custom:869cda85-2957-4209-bace-263bbfb61f0b/MiniMax-M2.7) were pushing tier cards beyond their grid column, breaking the 4-column layoutmin-width: 0on.routing-card__model-chipand.routing-card__chip-mainso the existingtext-overflow: ellipsisactually kicks inoverflow: hiddenon.routing-cardas a safety netflex-start→center)Test plan
Summary by cubic
Fixes tier cards overflowing their grid when model names are long by enabling proper ellipsis and clamping overflow. Also centers the provider icon in the model chip.
Written for commit a1ebb2b. Summary will update on new commits.