fix: extract API_KEY_PREFIX constant and validate prefix in OtlpAuthGuard#748
Merged
brunobuddy merged 1 commit intomainfrom Feb 20, 2026
Merged
fix: extract API_KEY_PREFIX constant and validate prefix in OtlpAuthGuard#748brunobuddy merged 1 commit intomainfrom
brunobuddy merged 1 commit intomainfrom
Conversation
…pAuthGuard Prevent regressions from the osk_ → mnfst_ prefix migration by: - Extracting API_KEY_PREFIX as a shared constant in both backend and plugin - Adding fast-fail prefix validation in OtlpAuthGuard (avoids DB round-trip for malformed tokens) - Fixing TEST_OTLP_KEY to use the mnfst_ prefix convention - Adding regression tests for prefix consistency in both packages - Adding cross-package check:api-prefix script for CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
API_KEY_PREFIX = 'mnfst_'as a shared constant in both the backend (api-key.constants.ts) and plugin (constants.ts), replacing hardcoded string literalsOtlpAuthGuard— tokens without themnfst_prefix are rejected immediately without a DB round-tripTEST_OTLP_KEYin e2e test helpers to use the correctmnfst_prefixosk_)npm run check:api-prefixscript that verifies both packages declare the same prefix value (for CI)Test plan
npm run check:api-prefixoutputsOK: API_KEY_PREFIX="mnfst_"