Fl_itides diagnostic crashes the model

[nichannah]

Inclusion of the Fl_itides diagnostic appears to crash the model, details below. If anyone has an idea please comment, otherwise I'll fix it as part of #147

*** Error in `../../build/gnu/ice_ocean_SIS2/debug/MOM6': double free or corruption (out): 0x000000000e10cda0 ***
Program received signal SIGABRT: Process abort signal.

With -fbounds-check:

At line 1389 of file ../../../../src/FMS/diag_manager/diag_manager.F90
Fortran runtime error: Array bound mismatch for dimension 1 of array 'rmask' (31/23)

In Valgrind:

==17085== Invalid write of size 4
==17085== at 0xE7503E: diag_manager_mod_MOD_send_data_3d (diag_manager.F90:1486)
==17085== by 0x7383B1: __mom_diag_mediator_MOD_post_data_3d_low (MOM_diag_mediator.F90:585)
==17085== by 0x7387F5: __mom_diag_mediator_MOD_post_data_3d (MOM_diag_mediator.F90:499)
==17085== by 0x5B1410: __mom_set_diffusivity_MOD_set_diffusivity (MOM_set_diffusivity.F90:793)
==17085== by 0x4A604B: __mom_diabatic_driver_MOD_diabatic (MOM_diabatic_driver.F90:475)
==17085== by 0x859B94: __mom_MOD_step_mom (MOM.F90:1228)
==17085== by 0x86F6E8: __ocean_model_mod_MOD_update_ocean_model (ocean_model_MOM.F90:406)
==17085== by 0x936E51: MAIN (coupler_main.F90:821)
==17085== by 0x943D4B: main (coupler_main.F90:130)

[nichannah]

I think this is just a bad allocation:

MOM_set_diffusivity.F90:448, nz should be nz+1 (?)

[adcroft]

Yes (to nz+1), based on the description and axis used in registration (axesTi) it looks like it is meant to be interface data. Not sure whose code this is to check with.