Merged
Conversation
This introduces multiple hacks to make things work: 1.) Rewrite jingle from/to peer to only contain VP8 codec. In particular we don't want to include error correcting pseudo-codecs like red, rtx etc. 2.) Use the video transceiver's setCodecPreferences() method to restrict to VP8, too. Also no error-correcting pseudo-codecs. 3.) Use uuid as stream id (not sure if this made any difference, though)
This makes it hard for spammers to mention everybody in a channel.
This new syntax allows to filter for attribute presence, something not
possible with either regex or verbatim matching of attribute values.
The new syntax introduces the '!' comparison operator alongside our '='
(verbatim) and '~' (regex) operators. This new operator requires the
value part to be not present (e.g. only ending a filter expression with
'!>' is allowed, but not with '!someValue>').
This allows for presence checks like `[node
check:@"{urn:some:namespace}someElement<thisAttribute!>"]` which is NO
if the attribute is not present and YES if it is present. Of course, the
abbreviated syntax `[node check:@"/<xxx!>"]` is also possible.
Traditionally in Monal, tests have not been automatically run against PRs. We are thinking of changing this and running tests against certain PRs. As a result, we want to skip tests that always fail. It so happens that these are all UI tests. As a result: delete most UI tests. They can always be re-written later. Leave one example of a test for future reference.
XCTest prepends the product name to the name of the .xctest file. For instance - if the target's product name is xyz, the xctest file would be named xyz.xctest. Since we have multiple test targets in the project, the lack of a product name caused two xctest files to be generated with the same name, and copied to the same build location. This caused build errors when trying to run the test targets. Therefore - ensure there is a product name provided for each test target, so that we can build and run the tests.
The previously used 500ms were too short, at least 916ms were needed in one of my measurements. Use 1500ms to be on the safe side.
- Added Estonian and Telugu translations - Fixed random black video feed on video calls - Make it harder for spammers to mention everybody: ignore mentions if more than 5 participants are mentioned per message - Properly display Visitor role in Channels - Add "Request Voice" button to contact details of moderated Channels
This reverts commit 843b147.
- Removed christmas special again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.