This repository was archived by the owner on Jun 6, 2025. It is now read-only.
🧹 Revert the grub audit matchers#191
Merged
atomic111 merged 3 commits intomondoohq:mainfrom Apr 3, 2023
Merged
Conversation
Signed-off-by: Michée lengronne <michee.lengronne@limawi.io>
Member
|
@micheelengronne, thanks for the improvement, but i want to include |
mm-weber
previously requested changes
Mar 30, 2023
Contributor
mm-weber
left a comment
mm-weber
left a comment
There was a problem hiding this comment.
Hey @micheelengronne, thank you for finding those faulty checks!
Are the proposed changes on your improvements agreeable to you?
Kind regards,
Manuel
Signed-off-by: Michée lengronne <michee.lengronne@limawi.io>
Signed-off-by: Michée lengronne <michee.lengronne@limawi.io>
Contributor
Author
|
I normally made the changes and the regex work. |
atomic111
approved these changes
Apr 1, 2023
Member
atomic111
left a comment
atomic111
left a comment
There was a problem hiding this comment.
@micheelengronne, thanks for the improvement
atomic111
approved these changes
Apr 1, 2023
chris-rock
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would revert the GRUB audit matchers. The current one does not work.