Skip to content

feat: implement front-end scaffolding#3

Merged
jordan-smith721 merged 3 commits intomongodb:mainfrom
jordan-smith721:front-end-scaffolding
Oct 24, 2025
Merged

feat: implement front-end scaffolding#3
jordan-smith721 merged 3 commits intomongodb:mainfrom
jordan-smith721:front-end-scaffolding

Conversation

@jordan-smith721
Copy link
Copy Markdown
Collaborator

@jordan-smith721 jordan-smith721 commented Oct 16, 2025

To run this, first navigate to the server/express folder and run:
npm run build
npm start

then in a separate terminal navigate to client/ and run:
npm run dev

The app should be running at localhost:3000

Copy link
Copy Markdown
Collaborator

@cbullinger cbullinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! left some comments, including some suggestions from augment, since i'm not super familiar with react/frontend (feel free to ignore if they're not applicable)

Comment thread client/package.json Outdated
Comment on lines +12 to +14
"react": "19.1.0",
"react-dom": "19.1.0",
"next": "15.5.5"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"react": "19.1.0",
"react-dom": "19.1.0",
"next": "15.5.5"
"react": "19.2.0",
"react-dom": "19.2.0",
"next": "16.0.0"

Comment thread client/package.json Outdated
"@types/react": "^19",
"@types/react-dom": "^19",
"eslint": "^9",
"eslint-config-next": "15.5.5",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"eslint-config-next": "15.5.5",
"eslint-config-next": "16.0.0",

Comment on lines +2 to +4
* Movies Page Styles
*
* CSS Module for the movies page component.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Movies Page Styles
*
* CSS Module for the movies page component.
* Movie Card Styles
*
* CSS Module for the movies card component.

Comment thread client/app/lib/utils.ts
Comment thread client/.gitignore
Comment thread client/app/layout.tsx Outdated
Comment thread client/app/lib/api.ts Outdated
return result.data;
} catch (error) {
console.error('Error fetching movies:', error);
// Return empty array instead of throwing to prevent page crash
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prob overkill, but maybe we can make use of NODE_ENV to be explicit about how you might handle this in dev vs. prod

Suggested change
// Return empty array instead of throwing to prevent page crash
// In development, throw the error to help with debugging
if (process.env.NODE_ENV === 'development') {
throw error;
}
// In production, return empty array with logged error to prevent page crash

Comment thread client/app/components/MovieCard/MovieCard.tsx
Comment thread client/app/lib/api.ts
@jordan-smith721 jordan-smith721 marked this pull request as ready for review October 24, 2025 19:59
@jordan-smith721 jordan-smith721 merged commit 788d96a into mongodb:main Oct 24, 2025
1 check passed
cbullinger added a commit that referenced this pull request Jan 31, 2026
- #1 Movie Cards: Make entire card clickable, enforce consistent heights, tone down checkbox
- #2 Top Toolbar: Remove batch buttons, add contextual bottom selection bar
- #3 Filters Bar: Replace mint/green with neutral gray borders and backgrounds
- #4 Navbar: Remove full-width green border and animated underline effect
- #5 Aggregations: Use light gray for row hover, tone down comment pills and show more button
- Additional: Remove bright green border from aggregations section headers

All changes improve visual hierarchy and reduce competing visual elements per reviewer feedback on PR #75.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants