Skip to content

CDRIVER-6310 pass username to custom OIDC callback#2285

Open
kevinAlbs wants to merge 5 commits intomongodb:masterfrom
kevinAlbs:CXX-2590
Open

CDRIVER-6310 pass username to custom OIDC callback#2285
kevinAlbs wants to merge 5 commits intomongodb:masterfrom
kevinAlbs:CXX-2590

Conversation

@kevinAlbs
Copy link
Copy Markdown
Collaborator

@kevinAlbs kevinAlbs commented May 1, 2026

Follow-up to #2147 discovered during CXX-2590. The username is not passed to a custom OIDC callback parameters. See CDRIVER-6310 for a repro.

Drive-by improvements:

  • Remove unnecessary check since mongoc_oidc_callback_destroy checks for NULL.
  • Remove unnecessary include of mcd-azure.h

Evergreen: https://spruce.corp.mongodb.com/version/69f476421da79a0007f74dfe/

kevinAlbs added 5 commits May 1, 2026 06:06
…che_t`

It is not only used for the environment callback, but also for the custom callback.
`mongoc_oidc_callback_destroy` does nothing for `NULL`
@kevinAlbs kevinAlbs requested review from connorsmacd and mdb-ad May 1, 2026 10:47
@kevinAlbs kevinAlbs marked this pull request as ready for review May 1, 2026 10:47
@kevinAlbs kevinAlbs requested a review from a team as a code owner May 1, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants