Skip to content

TOOLS-4102 Add a mise.toml with all of our tools#895

Merged
autarch merged 1 commit intomasterfrom
02-25-tools-4102_add_a_mise.toml_with_all_of_our_tools
Mar 2, 2026
Merged

TOOLS-4102 Add a mise.toml with all of our tools#895
autarch merged 1 commit intomasterfrom
02-25-tools-4102_add_a_mise.toml_with_all_of_our_tools

Conversation

@autarch
Copy link
Copy Markdown
Collaborator

@autarch autarch commented Feb 25, 2026

This adds a mise.toml, as well as some infrastructure for installing mise itself. However, nothing uses this yet. That will come in follow-up PRs.

Copy link
Copy Markdown
Collaborator Author

autarch commented Feb 25, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@autarch autarch force-pushed the 02-25-tools-4102_add_a_mise.toml_with_all_of_our_tools branch from fec1b39 to 344ea49 Compare February 25, 2026 19:39
Comment thread etc/mise.run.sh
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is copied from https://mise.run. I just don't want to do the curl ... | sh thing in the tools CI.

@autarch autarch force-pushed the 02-25-tools-4102_add_a_mise.toml_with_all_of_our_tools branch from 1d93133 to 6540086 Compare February 25, 2026 20:24
@autarch autarch force-pushed the 02-25-tools-4102_add_a_mise.toml_with_all_of_our_tools branch from 6540086 to a2a3687 Compare February 26, 2026 17:17
This adds a `mise.toml`, as well as some infrastructure for installing mise itself. However, nothing uses this yet. That will come in follow-up PRs.
@autarch autarch marked this pull request as ready for review February 27, 2026 15:14
@autarch autarch requested a review from a team as a code owner February 27, 2026 15:14
@autarch autarch requested review from nickweinberger and removed request for a team February 27, 2026 15:14
@autarch autarch force-pushed the 02-25-tools-4102_add_a_mise.toml_with_all_of_our_tools branch from a2a3687 to 8202f34 Compare February 27, 2026 15:14
Copy link
Copy Markdown
Collaborator

@nickweinberger nickweinberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since it's not being used yet, although I think I did notice one problem in mise.run.sh.

Comment thread etc/mise.run.sh
# tar is bsdtar or version is >= 1.31
if tar --version | grep -q 'bsdtar' && command -v zstd >/dev/null 2>&1; then
true
elif tar --version | grep -q '1\.(3[1-9]|[4-9][0-9]'; then
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regex is missing a closing ) right, so won't this always fall back?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Know you just copied this but that seems off.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually more broken than just missing a closing paren - jdx/mise#8430

Copy link
Copy Markdown
Collaborator Author

autarch commented Mar 2, 2026

Merge activity

  • Mar 2, 8:38 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 2, 8:38 PM UTC: @autarch merged this pull request with Graphite.

@autarch autarch merged commit f65db3f into master Mar 2, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants