feat: added sonarQube for code quality#42
feat: added sonarQube for code quality#42nasiruddinml wants to merge 1 commit intomonstar-lab-oss:masterfrom
Conversation
war1oc
left a comment
war1oc
left a comment
There was a problem hiding this comment.
Thanks a lot for the super fast PR @nasiruddinml san! 🎉
I have some comments, please take a look.
Also I think it's better not to have sonarqube in dev compose file as we may not want to run it everytime during development, I think we can have a discussion about this later in the meeting.
| - mysqldb | ||
|
|
||
| sonarqube: | ||
| container_name: sonarqube |
There was a problem hiding this comment.
A docker-compose generated container name would be more preferable in my opinion than a fixed name.
There was a problem hiding this comment.
It was set by mean to link with sonarscanner. Now, we can expose one more port for TCP connection. And omit this container_name.
| - sonarqube_temp:/opt/sonarqube/temp | ||
| ports: | ||
| - 9000:9000 | ||
| sonarscanner: |
There was a problem hiding this comment.
Can't we pass the sonar.properties to sonarqube container itself in volume /opt/sonarqube/conf rather than another container?
There was a problem hiding this comment.
Basically, sonar.properties most use case when we scan our code. Which handle by sonarscanner. So, I thought that users can change properties and make an easy scan.
3 participants
feat: added sonarQube docker setup for code quality