Added transparent background to overlays#1606
Open
joshrp wants to merge 3 commits intomoonlight-stream:masterfrom
Open
Added transparent background to overlays#1606joshrp wants to merge 3 commits intomoonlight-stream:masterfrom
joshrp wants to merge 3 commits intomoonlight-stream:masterfrom
Conversation
Added settings to control text color (no longer fixed yellow / red) and background color and transparency. This should help see the stats and messages while streaming. Defaulted to white text on a 50% transparent background
joshrp
commented
May 28, 2025
| ToolTip.visible: hovered | ||
| ToolTip.text: qsTr("Display real-time stream performance information while streaming.") + "\n\n" + | ||
| qsTr("You can toggle it at any time while streaming using Ctrl+Alt+Shift+S or Select+L1+R1+X.") + "\n\n" + | ||
| qsTr("The performance overlay is not supported on Steam Link or Raspberry Pi.") |
Author
There was a problem hiding this comment.
I removed this as the stats overlay seems to be working fine on my Pi5 Bookworm
80c9eb8 to
cd3063f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added settings to control text color (no longer fixed yellow / red) and background color and transparency.
This should help see the stats and messages while streaming.
Defaulted to white text on a 50% transparent black background.
I only added support for a few colours, it felt like overkill doing more. White, Black, Yellow for text, White, Black for backgrounds. Opacity only applies on the background, text is always 100% opaque, this might not be completely intuitive in labelling but the point of the overlay is to read the text so I thought that made more sense.
I'm not very familiar with this codebase or QT so I'd appreciate any other methods for doing this. The SDL part I'm pretty happy with and it should be very portable but maybe there's better calls to be using.
Some previews: