feat: bump deps and switch to node:test

[robertsLando]

cc @seriousme

[seriousme]

I'm working on this one. The standard stuff is relatively easy like on aedes-persistence-redis.
A bit more of a challenge is migrating the mongodb dependency from 4 to 6 (callbacks to promises and various other stuff)

[seriousme]

@robertsLando
@mcollina

Just to make sure I'm not spending loads of time on going on a path that is not appreciated:

Currently aedes-persistence-mongodb is build on mongodb@4 and relies nearly completely on callbacks and emitting ready events etc.

mongodb@4 was already deprecating callback style, but the current mongodb@6 just doesn't support it anymore.
class MongoPersistence extends CachedPersistence from aedes-cached-persistence
aedes-cached-persistence also still uses callbacks and ready events etc.
So does aedes-persistence .

Mixing callbacks with async/await is possible but creates more complex code which is hard to troubleshoot.

In aedes-persistence-level we solved this challenge by creating async functions outside of the class and "callbackify-ing" them only at the class level.

My proposal is to do the same for aedes-persistence-mongodb . However since the mongodb code is more complex than aedes-persistence-level I propose to keep the async code in a separate file so that its clear which code is async and use util/calbackify (where possible) or other means (where required) to provide callback support.

Do you agree?

Kind regards,
Hans

[robertsLando]

I agree with that. @mcollina ?

[mcollina]

agreed

[seriousme]

Ok, I'm almost there but I got stuck.

https://github.com/seriousme/aedes-persistence-mongodb/tree/mongodb6-dev contains my development branch in which I updated everything to mongodb@6

The abs tests work fine after I monkey-patched abstract.js in aedes-persistence (see moscajs/aedes-persistence#97 for the PR on that). And also the 'multiple persistences' test seems to work fine. The problem arises with the 'multiple persistences with passed db object and url' test which hangs while waiting for the stream event of mqemitter-mongodb in

 async function getEmitter (dbopts, emitter) {
  if (emitter) return emitter
  const mqEmitter = mqemitterMongo(dbopts)
  await waitForEventOnce(mqEmitter.status, 'stream')
  return mqEmitter
}

No emitter is passed to this function via the test so it gets the mqEmitter from mqemitterMongo.
It then needs to wait for the stream event but that never comes.

After digging deeper I found that the mqemitterMongo hangs in mqemitter-mongodb while calling that._collection.isCapped() at:

function waitStartup() {
    that._collection = that._db.collection(opts.collection)
    
      that._collection.isCapped(function (err, capped) {
        if (that.closed) { return }

https://github.com/mcollina/mqemitter-mongodb/blob/ec3dda8e298169ef1d48960da7f84485c5afb908/mqemitter-mongodb.js#L65

Which is a bit strange as it does not hang there in previous tests and it always hangs at exactly this point, so it seems no race condition. I checked using a that._db..command({ ping: 1 }) and the connection to MongoDB is available.

Any ideas why this call hangs?
Do we need to upgrade the mqemitter-mongdb to mongodb@6 first?

Kind regards,
Hans
ps. the { useNewUrlParser: true, useUnifiedTopology: true } are no longer required when starting the MongoDB client according to https://www.mongodb.com/community/forums/t/usenewurlparser-is-a-deprecated-what-to-do/304181

[seriousme]

Ok, thinking about a bit more it makes sense that it hangs.
In Mongdb@4 db.collection.isCapped() supported both callback style and async await
https://mongodb.github.io/node-mongodb-native/4.7/classes/Collection.html#isCapped

In Mongdb@6 db.collection.isCapped() ignores the parameters and returns a promise.
https://mongodb.github.io/node-mongodb-native/6.2/classes/Collection.html#isCapped

And hence the callback is never called.
Now the question is: what do we do about this hidden dependency on equal Mongodb versions?

Do we:
a) drop the test for bringing your own DB object so the emitter only uses MongoDB@4 and leave testing of the DB object with the emitter to the emitter itself
b) integrate the emitter functionality into aedes-persistence-mongodb so that they are always on the same version and we simplify maintenance
c) update the emitter to MongoDB@6, however that will probably require some of the emitters dependencies also need to be upgraded.
d) just leave mongodb@4 in aedes-persistence-mongodb

What do you think? @robertsLando @mcollina

Kind regards,
Hans

[mcollina]

The c) plan seems the most future proof

[seriousme]

Ok, I'll give it a try.

[robertsLando]

I agree with @mcollina 👍🏼