feat: add additional retained match patterns with multiple wildcards to abstract.js#103
Merged
robertsLando merged 2 commits intomainfrom May 22, 2025
Merged
feat: add additional retained match patterns with multiple wildcards to abstract.js#103robertsLando merged 2 commits intomainfrom
robertsLando merged 2 commits intomainfrom
Conversation
robertsLando
requested changes
May 21, 2025
Comment on lines
+125
to
+138
| test('look up retained messages with a + as first element', async t => { | ||
| t.plan(1) | ||
| await matchRetainedWithPattern(t, '+/world') | ||
| }) | ||
|
|
||
| test('look up retained messages with +/#', async t => { | ||
| t.plan(1) | ||
| await matchRetainedWithPattern(t, '+/#') | ||
| }) | ||
|
|
||
| test('look up retained messages with a + and # pattern with some in between', async t => { | ||
| t.plan(1) | ||
| await matchRetainedWithPattern(t, 'hello/+/world/#', { topic: 'hello/there/world/creatures' }) | ||
| }) |
Member
There was a problem hiding this comment.
shouldn't this also test passing an array of patterns?
robertsLando
approved these changes
May 22, 2025
Member
|
Minor release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds additional patterns with multiple wildcards to match on retained messages to the test suite in abstract.js
It aims to prevent regressions on moscajs/aedes-persistence-redis#123
Kind regards,
Hans