Remove asnyc-connect (redux-connect) and add react-router-redux#3974
Merged
tofumatt merged 1 commit intomozilla:masterfrom Nov 27, 2017
willdurand:remove-asyncconnect
Merged
Remove asnyc-connect (redux-connect) and add react-router-redux#3974tofumatt merged 1 commit intomozilla:masterfrom willdurand:remove-asyncconnect
tofumatt merged 1 commit intomozilla:masterfrom
willdurand:remove-asyncconnect
Conversation
Codecov Report
@@ Coverage Diff @@
## master mozilla/addons-frontend#3974 +/- ##
==========================================
+ Coverage 96.29% 96.35% +0.06%
==========================================
Files 185 185
Lines 3884 3869 -15
Branches 788 787 -1
==========================================
- Hits 3740 3728 -12
+ Misses 124 121 -3
Partials 20 20
Continue to review full report at Codecov.
|
Merged
tofumatt
approved these changes
Nov 27, 2017
Contributor
tofumatt
left a comment
tofumatt
left a comment
There was a problem hiding this comment.
I looked at this a few times (over the weekend and now) and compared it with my old branch. Everything looks covered and things work! Tested locally with SSR on and things to work. I say we 
😄
| }); | ||
|
|
||
| describe('REDUX_CONNECT_END_GLOBAL_LOAD', () => { | ||
| describe('LOCATION_CHANGE', () => { |
Contributor
There was a problem hiding this comment.
This is so much nicer anyway 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix mozilla/addons#9546
Fix mozilla/addons#10365
This PR completely removes
redux-async-connect/redux-connectand addsreact-router-reduxinstead to keep backward compatibility. (PS: it is the road to React 16)