Merged
Conversation
ErikBooijCB
approved these changes
Dec 21, 2018
gijsk
approved these changes
Dec 21, 2018
Contributor
gijsk
left a comment
gijsk
left a comment
There was a problem hiding this comment.
Hi! Thanks for the patch. Could you address the minor comment below before I merge this in? Thanks!
maludecks
force-pushed
the
sitename-feature
branch
from
6385081 to
88aef3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I am working in a project on my own, and it would be great if I could retrieve also the website name from the article using Readability, since it already gets all the metadata. At first I developed a decorator for it, but I think this could also be useful for more people :)
What do you guys think?
Thank you!