feat: allow bridge protocol versions in packet generation#156
Closed
seriousme wants to merge 1 commit intomqttjs:masterfrom
Closed
feat: allow bridge protocol versions in packet generation#156seriousme wants to merge 1 commit intomqttjs:masterfrom
seriousme wants to merge 1 commit intomqttjs:masterfrom
Conversation
Member
|
Cool enough seems this spec is not present anywhere on MQTT specs, but can be found in other MQTT modules like: https://github.com/eclipse-mosquitto/mosquitto/blob/3cbe805e71ac41a2a20cc9b2ea6b3b619f49554a/lib/send_connect.c#L153 |
Contributor
Author
|
Indeed, it seems to be convention and not part of the formal spec. |
Contributor
Author
|
The parser already supports it: Lines 171 to 173 in e39fb28 Looking at the parser we might want to make it symmetrical and use: protocolVersion: 4
bridgeMode: trueduring generation as well. |
Member
|
@seriousme yep agree, go for that |
Contributor
Author
|
I will push an update later today. |
Contributor
Author
|
I did some more research and the feature was already present: Lines 225 to 227 in e39fb28 So we can close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows bride protocol versions (MQTT protocol+128) to be generated as discussed in moscajs/aedes#1042 (review)