Fix hoisting of react statics between two forwardRef components#71
Merged
mridgway merged 1 commit intomridgway:masterfrom Dec 3, 2018
Merged
Conversation
Owner
|
Thanks! |
Owner
|
Published in v3.2.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #66.
Technically preventing to hoist
propTypesis wrong forreact < 16.4.1. Since facebook/react#12911 was introduced in a patch andpropTypesshouldn't be considered a non-react static anyway this should be fine.Edit:
Technically
nameis also a react static looking at https://github.com/facebook/react/blob/master/packages/shared/getComponentName.js concerned with the name of the component but I haven't seen it being documented.