Closed
Conversation
Closed
Owner
Author
|
I think on android I have to store bytes manually 😧 This is how the flutter library does it: mmkv.dart#L300-L352 - note, they're also just storing bytes. I'll have to encode the jsi::Object into bytes first, then store it. Same for decoding. 🤔 |
|
Dang ok. Sorry, I was hoping that the code was secretly ready on both platforms but figured there might be a good reason why it wasn't already integrated. Encoding the bytes essentially means reimplementing json.stringify again which is probably a bit much. |
|
@mrousavy Not sure why people would not just |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds support for:
and
This is very WIP and I'm not sure if it even works since I think MMKV (protobuf) has to know the size of the object it should retrieve.
Closes #2