Skip to content

[Card] add containerStyle prop#4085

Merged
mbrookes merged 1 commit intomui:masterfrom
RahavLussato:patch-1
May 2, 2016
Merged

[Card] add containerStyle prop#4085
mbrookes merged 1 commit intomui:masterfrom
RahavLussato:patch-1

Conversation

@RahavLussato
Copy link
Copy Markdown
Contributor

@RahavLussato RahavLussato commented Apr 25, 2016

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

add childrenStyle prop to have the ability to customize the inner div styles.
i needed this to give the div width of 100% then i can align the header to center and the body to left.

Comment thread src/Card/Card.js
children: PropTypes.node,
/**
* Override the inline-styles of the children element.
*/
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if containerStyle wouldn't be better. I would be using childrenStyle if we were cloning the children.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done :)

@RahavLussato
Copy link
Copy Markdown
Contributor Author

@oliviertassinari i did this changed

@oliviertassinari oliviertassinari changed the title [Card] add childrenStyle prop [Card] add containerStyle prop Apr 27, 2016
Comment thread src/Card/Card.js
* Can be used to render elements inside the Card.
*/
children: PropTypes.node,
/**
Copy link
Copy Markdown
Member

@oliviertassinari oliviertassinari Apr 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about Override the inline-styles of the container.?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done :)

@nathanmarks
Copy link
Copy Markdown
Contributor

@RahavLussato can you squash?

@RahavLussato
Copy link
Copy Markdown
Contributor Author

@nathanmarks i did some clumsy squash, can you squash on merge ?

@mbrookes
Copy link
Copy Markdown
Member

mbrookes commented May 1, 2016

@RahavLussato - git rebase -i HEAD~3 and 'f' to flatten. Please could you also 'r' (reword) the commit to match the PR title?
Thanks.

@RahavLussato
Copy link
Copy Markdown
Contributor Author

@mbrookes @nathanmarks is it ok now ?

@mbrookes
Copy link
Copy Markdown
Member

mbrookes commented May 1, 2016

@RahavLussato Nearly, you still need to reword the commit fro "[Card] add childrenStyle prop: to "[Card] add containerStyle prop"

add containerStyle prop to have the ability to customize inner div styles.
i needed this to give the div width of 100% then i can align the header to center and the body to left.

Update Card.js

Update Card.js

Update Card.js

rename childrenStyle to containerStyle

Update Card.js

[Card] add containerStyle prop
@RahavLussato
Copy link
Copy Markdown
Contributor Author

@mbrookes @nathanmarks done :)

@mbrookes
Copy link
Copy Markdown
Member

mbrookes commented May 2, 2016

@RahavLussato Thanks for your contribution! 👍

@mbrookes mbrookes merged commit 99ac508 into mui:master May 2, 2016
@RahavLussato RahavLussato deleted the patch-1 branch May 17, 2016 09:28
@zannager zannager added the scope: card Changes related to the card. label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: card Changes related to the card.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants