[Style] Add a withWidth HOC#4126
[Style] Add a withWidth HOC#4126oliviertassinari merged 5 commits intomui:masterfrom oliviertassinari:with-width-hoc
Conversation
|
@callemall/material-ui There are unrelated topics inside this PR. If you think this chunk is too big. I can break it down. |
That's fine by me! As long as we're consistent 😄
🎉 Finally! 🎉 |
|
@oliviertassinari doing a PR for that right now |
|
Should we put the Thoughts? |
| */ | ||
| style: PropTypes.object, | ||
| width: PropTypes.string.isRequired, | ||
| width: PropTypes.number.isRequired, |
There was a problem hiding this comment.
Tabs documentation page -- I'm getting this warning in my console now:
warning.js:44 Warning: Failed propType: Invalid prop `width` of type `string` supplied to `InkBar`, expected `number`. Check the render method of `Tabs`.
@oliviertassinari Should we just do that as part of this PR? |
Yes, |
Done! I have
|
|
@oliviertassinari This looks good to me. Nice commits! |
|
Nice work @oliviertassinari! 💯 |
|
@oliviertassinari: I was going to use this new component but the widths used don't match the Material Design window sizes. Is there are reason they are different? |
|
@damonmaria Good question, Material-UI completely overlook the responsive aspect of the specification. In this PR, I was focusing on porting the mixin into a high order component. |
EventListenercomponent.styleResizablemixin and remove it from the documentation. That's was our last mixin #RIP. Now, we should be able to enforcereact/prefer-es6-classes.material-ui/libfrom the documentation.