Conversation
style to EnhancedButtonstyle to EnhancedButton
212a864 to
fff9445
Compare
| transition: transitions.easeOut(), | ||
| }, | ||
| button: { | ||
| button: Object.assign({ |
|
@c089 @oliviertassinari This is kind of like that other one. Personally, I think that we have an issue similar to this with most components that have |
True, that would be confusing. Would you accept this PR if it added a
Agreed, I was surprised by this here as well... |
|
vote for |
fff9445 to
b696210
Compare
style to EnhancedButtonbuttonStyle prop
|
@kidwm @nathanmarks I updated the PR to add a I noticed this is inconsistent with the API of |
b696210 to
7599b38
Compare
7599b38 to
01cd673
Compare
|
@mbrookes How do we make this consistent when one button has a completely different root node? ahhh! 🔨 🔥 |
|
@nathanmarks With a single Button component? 😄 |
53b828e to
ea2538e
Compare
|
@c089 Thanks for this PR. We have added a |
Closes #4345