[pickers] Fix onAccept not being called after external value change#22131
Open
michelengelen wants to merge 1 commit intomui:masterfrom
Open
[pickers] Fix onAccept not being called after external value change#22131michelengelen wants to merge 1 commit intomui:masterfrom
onAccept not being called after external value change#22131michelengelen wants to merge 1 commit intomui:masterfrom
Conversation
Bundle size
Deploy previewhttps://deploy-preview-22131--material-ui-x.netlify.app/ Check out the code infra dashboard for more information about this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the
onAcceptcallback (and consequently theClearaction in the picker's action bar) would fail to fire if the picker's value had been updated externally (e.g., via a controlledvalueprop from Redux or parent state) since the last time the picker was opened or a value was committed.Fixes #21962