[charts-pro] Auto-select range button matching current zoom#22137
Draft
JCQuintas wants to merge 5 commits intomui:masterfrom
Draft
[charts-pro] Auto-select range button matching current zoom#22137JCQuintas wants to merge 5 commits intomui:masterfrom
JCQuintas wants to merge 5 commits intomui:masterfrom
Conversation
1 task
Bundle size
Deploy previewCheck out the code infra dashboard for more information about this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChartsToolbarPronow mark themselves as selected whenever the current zoom matches their computed range, soinitialZoom(or controlledzoomData) landing on a button's range highlights it on first render without user interaction.activeRangeButtonKeystate,setActiveRangeButtonKeyinstance method, andselectorChartActiveRangeButtonKeyselector have been removed. This also drops the manual resets previously needed on every pan/wheel/zoom.<span>wrappers around the zoom-in / zoom-out triggers inChartsToolbarCustomToolbarsoTooltipno longer receives a disabled<button>as a direct child (was producing a console warning).ChartsToolbarRangeButtonsInitialSelectionillustrates the behavior.