[DataGrid] [docs] Only use one aria-label on customizing checkbox column code snippet #22141
Open
StylesTrip wants to merge 7 commits intomui:masterfrom
Open
[DataGrid] [docs] Only use one aria-label on customizing checkbox column code snippet #22141StylesTrip wants to merge 7 commits intomui:masterfrom
StylesTrip wants to merge 7 commits intomui:masterfrom
Conversation
… aria-label on the checkbox and remove both labels being read by screenreaders
Bundle size
Deploy previewCheck out the code infra dashboard for more information about this PR. |
…rip/mui-x into checkbox-column-customize-update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The code snippet found under the Customizing the checkbox column section which is under the Custom checkbox column section -> https://mui.com/x/react-data-grid/row-selection/#custom-checkbox-column is generating two aria-labels, one for the tooltip and one for the checkbox input. Both are being read by, at the least, Voiceover on Mac.
Proposed solution
The proposed changes in this request uses the
describeChildprop on the Tooltip and updates the aria-label on the GridRowCheckbox. This removes the aria-label on the tooltip and Voiceover now only reads the aria-label from the checkbox input. This change keeps the Tooltip visual label the same.Demo of changes
I also created a demo to show the difference between the two: https://stackblitz.com/edit/np5rf22s?file=src%2FDemo.tsx