-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[x-license] Improve v9 license key version mismatch error guidance #22180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 3 commits
9f5c912
8434b04
e1914b0
f1ae113
ee05ecf
b5d2c46
f5a01da
f5924dd
9671091
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| import { MarkdownElement } from '@mui/internal-core-docs/MarkdownDocs'; | ||
|
|
||
| export default function V9LicenseUpgradeWarning() { | ||
| return ( | ||
| <MarkdownElement> | ||
| <aside className="MuiCallout-root MuiCallout-warning"> | ||
| <div className="MuiCallout-icon-container"> | ||
| <svg focusable="false" aria-hidden="true" viewBox="0 0 20 20"> | ||
| <use xlinkHref="#warning-icon" /> | ||
| </svg> | ||
| </div> | ||
| <div className="MuiCallout-content"> | ||
| <p> | ||
| If you're upgrading from v8 to v9, you'll need to generate a new license key | ||
| from your <a href="https://mui.com/r/x-license-account/">MUI Store account</a>. The new | ||
| v9 key inherits the same expiration date as your existing v8 key, so there's no | ||
| extra cost during your current term. See{' '} | ||
| <a href="https://mui.com/r/x-license-key-upgrade/"> | ||
| How can I generate a v9 license key? | ||
| </a>{' '} | ||
| for step-by-step instructions. | ||
| </p> | ||
| <p> | ||
| When it's time to renew, you'll need to choose which key to renew, note that | ||
| v9 renewals are priced differently from v8 renewals. | ||
| </p> | ||
| </div> | ||
| </aside> | ||
| </MarkdownElement> | ||
| ); | ||
| } | ||
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -63,10 +63,13 @@ export function showLicenseKeyVersionMismatchError() { | |||||||
| showError([ | ||||||||
| 'MUI X: License key version mismatch.', | ||||||||
| '', | ||||||||
| 'The license key you are using is not compatible with the version of the MUI X packages installed.', | ||||||||
| 'This happens when using a license key from a previous major version (e.g. a v8 license with v9 packages).', | ||||||||
| // #npm-tag-reference | ||||||||
| 'The license key you are using was issued for an older major version of MUI X (e.g. a v8 license with v9 packages installed).', | ||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is needed so we don't forget to update the versions on the next major.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we do the opposite, parametrize the console to be specific?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||||||||
| 'Each major version uses a different license key format, so the key needs to be regenerated — your existing license is not lost.', | ||||||||
| '', | ||||||||
| 'To resolve this, you can either get an new license key at https://mui.com/r/x-get-license or from your account profile at https://mui.com/store/account/licenses/, or downgrade to an older MUI X version that matches your current license key.', | ||||||||
| 'To resolve this, you can either:', | ||||||||
| '- Generate a new key compatible with the installed version from your account at https://mui.com/r/x-license-account/ (free for existing customers, the new key inherits your current expiration date). More details at https://mui.com/r/x-license-key-upgrade/.', | ||||||||
| '- Or downgrade the MUI X packages to the major version that matches your current license key.', | ||||||||
| ]); | ||||||||
| } | ||||||||
|
|
||||||||
|
|
||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick, but shouldn't the link be relative?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was correct. This should be a global link so it continues to redirect to the right place as we introduce changes to our billing infrastructure. It shouldn't be tied to an old version redirect rule because we don't want to have to update old versions redirect rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted.