[data grid] Inherit icon fontSize from baseIconButton size#22187
Open
imxv wants to merge 2 commits intomui:masterfrom
Open
[data grid] Inherit icon fontSize from baseIconButton size#22187imxv wants to merge 2 commits intomui:masterfrom
imxv wants to merge 2 commits intomui:masterfrom
Conversation
Bundle size
Deploy previewhttps://deploy-preview-22187--material-ui-x.netlify.app/ Check out the code infra dashboard for more information about this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12900
Changelog
<GridActionsCellItem>previously hardcodedfontSize="small"on its icon, sopassing
size="large"produced a large button with a small icon. The icon nowuses
fontSize="inherit", letting it scale with the enclosingIconButtonsize — the fix suggested by @michelengelen in #12900.
cc @michelengelen