Skip to content

Positional Audio support for Rocket League and Left 4 Dead 2 plugin update#2196

Closed
davidebeatrici wants to merge 6 commits intomumble-voip:masterfrom
davidebeatrici:master
Closed

Positional Audio support for Rocket League and Left 4 Dead 2 plugin update#2196
davidebeatrici wants to merge 6 commits intomumble-voip:masterfrom
davidebeatrici:master

Conversation

@davidebeatrici
Copy link
Copy Markdown
Member

No context nor identity support available yet.

Thanks to @mkrautz on Mumble IRC Chat for the compile fix (#2195) and for helping me about memory addresses (pModule).
This probably would not have been possible without his help.
Thanks also to @hacst: he tried to troubleshoot my compile problem.

Thanks to @mkrautz on Mumble IRC Chat for the compile fix (#2195) and for helping me about memory addresses (pModule).
This probably would not have been possible without his help.
Thanks also to @hacst: he tried to troubleshoot my compile problem.
Thanks to @mkrautz on Mumble IRC Chat for the compile fix (#2195) and for helping me about memory addresses (pModule).
This probably would not have been possible without his help.
Thanks also to @hacst: he tried to troubleshoot my compile problem.
@mkrautz
Copy link
Copy Markdown
Contributor

mkrautz commented Apr 10, 2016

Hi @davidebeatrici,

Maybe we should add a version to the plugin as well?

Also, could you please use the new-style license header from https://github.com/mumble-voip/mumble/blob/master/LICENSE.header? All new code we add should use that header.

I might get to this before you, and if so, I can fix it for you before landing...

Thanks!

@davidebeatrici
Copy link
Copy Markdown
Member Author

Hi @mkrautz,

I didn't add the game version because I thought it wasn't needed: there will be an update soon and we will see if the offsets will change or not; I decided to add the version to the plugin description anyway, if the offsets will not change I will remove the version 😉

I replaced the license header with the new one 😄

Support for Left 4 Dead 2 version 2.1.4.4
@davidebeatrici davidebeatrici changed the title Positional Audio support for Rocket League Positional Audio support for Rocket League and Left 4 Dead 2 plugin update Apr 10, 2016
@davidebeatrici
Copy link
Copy Markdown
Member Author

I wanted to do another pull request for the Left 4 Dead 2 plugin update, but GitHub automatically put the commit into this. I renamed the title 😉

Should I update the license header for L4D2 plugin?

@mkrautz
Copy link
Copy Markdown
Contributor

mkrautz commented Apr 10, 2016

No, this seems fine!

@davidebeatrici
Copy link
Copy Markdown
Member Author

Ok 👍
I will try to add context support to Rocket League's plugin, it shouldn't be too complicated; next thing to the context will be the identity support, I will almost certainly need some help 😄

@mkrautz
Copy link
Copy Markdown
Contributor

mkrautz commented Apr 10, 2016

Thanks. Landed as 80d0354 and 8017a01.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants