FIX(client): Replace legacy sourceforge DBus domain with info.mumble#7155
FIX(client): Replace legacy sourceforge DBus domain with info.mumble#7155M-Shaheer-Ahsan wants to merge 1 commit intomumble-voip:masterfrom
Conversation
WalkthroughThe D-Bus namespace has been migrated from 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/mumble/DBus.h`:
- Line 16: The adaptor currently only exports the D-Bus interface
"info.mumble.Mumble" (Q_CLASSINFO line in src/mumble/DBus.h) which breaks
clients expecting the legacy "net.sourceforge.mumble.Mumble" used in main.cpp
fallback logic (see lines ~599 and ~620); fix by exposing both interfaces—either
add a second Q_CLASSINFO entry or otherwise ensure the same adaptor instance is
registered with both interface names so the adaptor class in DBus.h exports both
"info.mumble.Mumble" and "net.sourceforge.mumble.Mumble" to preserve backward
compatibility with the fallback code paths in main.cpp.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6e11bae4-8d17-4a7e-b173-acbcfcb76512
📒 Files selected for processing (3)
src/mumble/DBus.cppsrc/mumble/DBus.hsrc/mumble/main.cpp
M-Shaheer-Ahsan
force-pushed
the
fix/replace-sourceforge-domain
branch
from
05a699d to
665639e
Compare
src/mumble/DBus.cpp
Outdated
| default: | ||
| QDBusConnection::sessionBus().send(msg.createErrorReply( | ||
| QLatin1String("net.sourceforge.mumble.Error.transmitMode"), QLatin1String("Invalid transmit mode"))); | ||
| QLatin1String("info.mumble.Error.transmitMode"), QLatin1String("Invalid transmit mode"))); |
There was a problem hiding this comment.
The exact end point name should probably be retrieved via a virtual member function so the new interface uses the new name but the legacy interface still uses the old one 🤔
There was a problem hiding this comment.
Thanks for that pointer, I overlooked that when I was creating the new class. I truly appreciate the help <3
M-Shaheer-Ahsan
force-pushed
the
fix/replace-sourceforge-domain
branch
2 times, most recently
from
76ff10e to
a9d150a
Compare
|
I missed a semi-colon lol 😅 |
The DBus interface and error reply strings still referenced the old net.sourceforge.mumble domain. These have been updated to use info.mumble instead. For backwards compatibility, the old service name is still registered alongside the new one, and when connecting to an existing Mumble instance the client tries the new interface name first and falls back to the old one. Fixes mumble-voip#6963
M-Shaheer-Ahsan
force-pushed
the
fix/replace-sourceforge-domain
branch
from
a9d150a to
eed9438
Compare
2 participants
The DBus interface and error reply strings still referenced the old net.sourceforge.mumble domain. These have been updated to use info.mumble instead.
For backwards compatibility, the old service name is still registered alongside the new one, and when connecting to an existing Mumble instance the client tries the new interface name first and falls back to the old one.
Fixes #6963
Checks