FIX(client, macOS): Move Quit menu to application menu on macOS

[maxer137]

On macOS, the "Quit Mumble" option was incorrectly placed under the Server menu instead of the standard application menu. This commit adjusts the menu placement so that the quit action appears under the application menu on macOS, aligning with typical macOS UI conventions.

It also disables the custom icon for the preferences option. This too is to align with typical macOS UI conventions.

• Exclude Quit action from Server menu on macOS
• Set menuRole of Quit action to QAction::QuitRole in UI file
• Hide custom preferences icon in menu on macOS

Implements #7151

Checks

• My commits follow the commit guidelines

[coderabbitai]

Walkthrough

This pull request implements macOS-specific UI adjustments to the Mumble client's menu system. The changes hide the settings/config action icon in the menu on macOS, set the Quit action's menu role to QAction::QuitRole, and remove the Quit option from the server context menu on macOS by conditionally excluding it from compilation on that platform.

Possibly related issues

• Move the Quit button to the "Mumble" application menu on macOS #7151: Implements the requested behavior of moving the Quit menu item to the application menu on macOS through menuRole assignment and removal from the server context menu.

Suggested labels

client, macOS, ui

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: moving the Quit menu to the application menu on macOS following standard conventions.
Description check	✅ Passed	The description covers the main changes, provides context about macOS conventions, lists specific modifications, and includes the required commit guidelines checkbox marked as completed.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/mumble/MainWindow.ui`:
- Around line 259-261: The tray menu unconditionally adds the Quit action
(qaQuit) while other menus guard it on macOS; update the TrayIcon code to wrap
the creation/adding of qaQuit in a platform guard (`#ifndef` Q_OS_MACOS / `#endif`).
Locate the place where QAction* qaQuit is constructed or added to the
tray/context menu in the TrayIcon implementation (e.g., TrayIcon::... or
createContextMenu) and enclose that block with the same `#ifndef` Q_OS_MACOS used
in MainWindow::... so qaQuit is omitted on macOS for consistency.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c9a58a27-f13c-4d4b-97ed-3389817184eb

📥 Commits

Reviewing files that changed from the base of the PR and between c73b065 and 7ef078b.

📒 Files selected for processing (2)

• src/mumble/MainWindow.cpp
• src/mumble/MainWindow.ui

[maxer137]

Before changes:

After changes:

[Hartmnt]

You can ignore the coderabbit suggestion as it is BS