Chapter time#1203
Open
tsipinakis wants to merge 2 commits into
Open
Conversation
Member
|
Yeah, the big change you are talking about is that we now calculate the progress in the frontend instead of it being pushed every second by backend. Also the details in player.current_media now are always accurate, regardless the source as the player may be playing some live source instead of the our queue. If you don't have time atm to adjust the PR to those changes, me or @stvncode can have a look next week |
Author
I don't have a lot of time at the moment so if you can help resolve the conflicts it'd be great |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening #1090. Which was closed after a wrong force push with an empty compare (github doesn't like it it seems).
@marcelveldt I see there was significant new changes in this part of the code, I'm not sure I have the time to re-implement this on top of the new things, it'd be great if you could help see this merged?