Refactor settings Edit config with shadcn comps#1823
Draft
stvncode wants to merge 5 commits into
Draft
Conversation
stvncode
commented
May 30, 2026
stvncode
commented
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Settings “edit config” experience to use the project’s shadcn-style UI components and a TanStack Vue Form–based form model, replacing a number of Vuetify widgets across provider/core/player settings views.
Changes:
- Replace Vuetify controls in settings views with shadcn UI components (Select/Switch/Slider/Input/Dialog/Alert/Card/etc.).
- Rework
EditConfig.vueto use@tanstack/vue-form+ a new Zod-backed schema/helpers (src/lib/forms/config-entry.ts) for validation, defaults, disabled-state, and “unsaved changes” detection. - Introduce
ConfigEntryRow.vueas a wrapper row component and add a new shadcn-styleAlertcomponent.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| src/views/settings/PlayerOptionField.vue | Refactors player option inputs to shadcn Field/Select/Switch/Slider/Input. |
| src/views/settings/EditProvider.vue | Migrates provider settings header/banner/dialog/overlay to shadcn components. |
| src/views/settings/EditPlayerOptions.vue | Converts player options cards to shadcn Card components. |
| src/views/settings/EditPlayer.vue | Migrates player settings header/banners/dialog/overlay to shadcn components. |
| src/views/settings/EditCoreConfig.vue | Migrates core config header and loading overlay to shadcn components. |
| src/views/settings/EditConfig.vue | Replaces Vuetify form implementation with TanStack Vue Form + new row rendering and protocol accordion. |
| src/views/settings/ConfigEntryRow.vue | New component to render a config entry + advanced/help affordances. |
| src/views/settings/ConfigEntryField.vue | Refactors individual field rendering to shadcn components and TanStack field APIs. |
| src/views/settings/AddProviderDetails.vue | Migrates add-provider flow layout/overlay to shadcn components. |
| src/lib/forms/config-entry.ts | New shared helpers: defaults, schema/validation, disabled-state detection, “value entry” filtering. |
| src/components/ui/alert/* | New shadcn-style Alert component + variants and subcomponents. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.