Skip to content

Migrate timeline slider to reka-ui, fix tap not skipping correctly#1857

Open
pierosavi wants to merge 9 commits into
music-assistant:mainfrom
pierosavi:improve-slider
Open

Migrate timeline slider to reka-ui, fix tap not skipping correctly#1857
pierosavi wants to merge 9 commits into
music-assistant:mainfrom
pierosavi:improve-slider

Conversation

@pierosavi

Copy link
Copy Markdown

Closes music-assistant/backlog#67

Migrated Vuetify slider to Reka's https://reka-ui.com/docs/components/slider
Since Reka's doesn't support ticks for chapters, I extended the component to add the functionality as close as possible

Screencast_20260603_222910.webm

I kept the UI as similar as possible to Vuetify's
Externalized the chapter computer, added tests

Screencast_20260603_223148.webm

@pierosavi

Copy link
Copy Markdown
Author

I just noticed the PR #1855 from @kissu , even though we fixed the same issue we had different approaches, I went with replacing the component with Reka slider and added chapter ticks

Happy to pull their bounce fix into my branch so we have the best of both worlds, waiting for confirmation from maintainers

@kissu

kissu commented Jun 4, 2026

Copy link
Copy Markdown

Haha, different approaches indeed. 🤗
The team is also migrating away from Vuetify so that makes sense to help from that angle. 💯

@MarvinSchenkel

Copy link
Copy Markdown
Contributor

Absolute gold that the frontend is getting some love from the community <3. Steven is a bit swamped so close to the 2.9 release, but we'll pick this up verrry soon after the release next Wednesday 🙏

@kissu

kissu commented Jun 4, 2026

Copy link
Copy Markdown

Yeah I figured but those FE contributions can definitely wait some time. 😄
And yes, it could definitely use some help to get to the extra mile with the migration/tooling! 💖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tapping progress slider acts like volume, does small step. That's unexpected I think. Can't jump to middle of song, valid use case

3 participants