Unify list row layout and refine play affordances#1862
Open
MarvinSchenkel wants to merge 6 commits into
Open
Conversation
Bring the tracks, playlist and other list views in line with the new album-overview row style and rework how the play button is presented. - Apply the album title font and move duration to the right on all list rows; the track number stays exclusive to the album view. - Desktop (hover-capable): a blue play button reveals on hover, replacing the album art (or swapping in for the track number in album view). - Touch devices (phones and tablets): an explicit play button sits on the right, just before the menu, so tapping the album art never starts (possibly remote) playback. - Show the favourite heart on the playlist tracks view for consistency. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Non-playable browse folders (e.g. recommendations, radio stations) don't render the blue play button, so blurring the artwork on hover left the icon dimmed with nothing to reveal. Gate the hover blur (and the album track-number fade) on item.is_playable via an is-playable class. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
@MarvinSchenkel, we can maybe close this and put in in the discord thread for taking it again when tackling the subject for next release ? |
Contributor
Author
|
I put it indraft for now |
…ith-album # Conflicts: # src/components/ListviewItem.vue
… fall through to the row
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the tracks, playlist and other list views in line with the new album-overview row style (#1828) and reworks how the play button is presented, with a deliberate goal of never triggering playback by accident (important for MA, where playback can target speakers in other rooms).
Changes
(hover: none)rather than viewport width, so tablets (e.g. iPad) keep an explicit button instead of an unreachable hover affordance.Testing
eslintandvue-tsc --noEmitclean (pre-existingrequire-default-propwarnings only).vitest, 176 tests).