Add explicit_only filter to smart playlist rules#1865
Conversation
|
This could be contentious as while I am a fan Marcel has pointed out in the past that this will only work for some streaming providers that send the metadata. Thus you can seelct the option but still get explicit songs which obviously wont be what the user expects. |
|
We could also show the "best effort" warning banner for rule-based filters — see screenshot. This makes it clear to users that filter results depend on provider metadata availability, not just in seed mode.
Note: the view will look slightly different once PR #1866 (field icons) is merged.
|
|
I haven't following this closely enough. Is that screenshot for in-library only? |
|
This is a suggestion for the "From my library" section, showing how the "Best Effort" warning banner could look with the filters (and the explicit_only filter). This banner is already displayed in the "Discover" filters. The explicit_only filter could also be implemented there. |
|
OK that sounds OK. The point I was going to make is favourite and explicit are only available for in_library items. (Probably genre, album type and year as well but I would have to confirm) |
|
I've double-checked my current development: "Discover" post filters (with existing "Best Effort" warning banner)
"From my library" filters (without the "Best Effort" warning banner)
If it turns out that the "Explicit" option in "Discover" isn't working, I can remove it when I make this pull request "ready for review". |
|
My point is you would still need the banner on in-library for explicit because many (most?) streaming providers don't send that flag and for local files there isn't a tag for it. The best you could probably do is a checkbox with something like "skip tracks with explicit lyrics when identified" |
- Add 'Allowed', 'Explicit only', and 'Not allowed' options - 'Allowed' (null) and undefined treated same on backend (no restriction) - Default to 'Not allowed' when adding explicit filter - Show best-effort info for both library and seed modes - Rename explicit_only to explicit in API interface
fef98ff to
105cb60
Compare

What does this implement/fix?
Adds UI for the
explicitfilter in smart playlist rules with clear, user-friendly options:UI improvements:
null(allowed),true(explicit only),false(not allowed)Related:
explicit_onlytoexplicit)Screenshots