Don't use server dynamic colors#599
Closed
seadowg wants to merge 9 commits into
Closed
Conversation
These resulted in a mismatch with the player colors as the latter comes from the server.
Collaborator
Author
|
|
formatBCE
reviewed
Jun 12, 2026
formatBCE
left a comment
formatBCE
left a comment
Collaborator
There was a problem hiding this comment.
Good code. If we decide to remove that - let's merge.
seadowg
changed the title
Collaborator
Author
|
Closing in favour of another PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed, this removes the server colors (which creates inconsitencies) and just uses the locally calculated colors everywhere. I've also made sure that animations only run once for a navigation entry so you don't see colors pop back in when going back.