Add auto discovery to HEOS#3056
Merged
Merged
Conversation
Contributor
|
Good news! Please PR the beta docs as well. |
OzGav
added a commit
to music-assistant/beta.music-assistant.io
that referenced
this pull request
Jan 30, 2026
Adjusted information regarding discovery, and manual IP configuration changes in music-assistant/server#3056 Also adjusted zone notes a bit
marcelveldt
reviewed
Feb 1, 2026
marcelveldt
reviewed
Feb 1, 2026
MarvinSchenkel
approved these changes
Feb 2, 2026
MarvinSchenkel
left a comment
MarvinSchenkel
left a comment
Contributor
There was a problem hiding this comment.
Great work @Tommatheussen 👏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in the initial HEOS PR, discovery was something still be done. With this PR, it's possible to do these things:
Still manually configure the HEOS controller, useful to force a device to be used as controller. If manual IP is configured, mDNS does nothing.
When mDNS players are found, take the first one that comes in and use that to connect to. If this device does have the right properties (supported firmware, wired connection), it will connect to 1 of the preferred hosts instead.
When a player change event comes in from HEOS, run the player discovery again. Instead of unregistering a player when it is not found anymore, we mark it as unavailable.