Restore 'ignore volume reports' setting for AirPlay players#4172
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Restores the missing AirPlay player setting “Ignore volume reports sent by the device itself” in get_config_entries, ensuring the UI again exposes a backend-supported option and adding a regression test to prevent future removal.
Changes:
- Re-add
CONF_IGNORE_VOLUMEas an advanced “protocol_generic” player config entry for AirPlay players. - Keep volume-report ignoring applicable regardless of RAOP vs AirPlay2 (no longer RAOP-only in config UI).
- Add a regression test asserting the config entry is present in
AirPlayPlayer.get_config_entries().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
music_assistant/providers/airplay/player.py |
Restores the ignore_volume ConfigEntry in the AirPlay player configuration entries. |
tests/providers/airplay/test_player.py |
Adds a regression test verifying the ignore_volume config entry is included. |
marcelveldt
approved these changes
Jun 11, 2026
marcelveldt
pushed a commit
that referenced
this pull request
Jun 13, 2026
anatosun
pushed a commit
to anatosun/music-assistant-server
that referenced
this pull request
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
PR #3210 accidentally replaced the "Ignore volume reports sent by the device itself" config entry with the new latency entry in
get_config_entries, so the setting disappeared from the UI while the backend still honors it. This restores the config entry (advanced, generic protocol category).ignore_volumeConfigEntry with its original label/descriptiondepends_ononce AirPlay2 gained DACP support is now fulfilled, and volume feedback reachesupdate_volume_from_devicefor both protocolsRelated issue: music-assistant/support#5603
Types of changes
bugfixnew-featureenhancementnew-providerbreaking-changerefactordocumentationmaintenancecidependenciesChecklist
pre-commit run --all-filespasses.pytestpasses, and tests have been added/updated undertests/where applicable.music-assistant/modelsis linked.music-assistant/frontendis linked.