Transparent pngs still showing as black in certain places

[kieranhogg]

What version of Music Assistant has the issue?

dev

How is the MA server installed?

Home Assistant OS Addon

Mandatory: Carefully read the Troubleshooting FAQ and confirm that

• I have examined the logs and tried to resolve this issue
• I have fixed any errors or warnings in the logs that relate to tags
• I am not running MA across a VPN, VLAN, subnet, behind a firewall, or using local SSL or have any other complex network setup
• I am not using or have disabled tools such as AdGuard, Pi-hole or pfSense and retested
• I have checked my network setup to ensure mDNS/multicast is not being blocked
• I have reviewed the Open and Closed Issues and Discussions
• I have reviewed the applicable player or music provider documentation
• I have reviewed the MA Status Page
• I have tried restarting MA and rebooting the host

As Applicable: Carefully read the Troubleshooting FAQ and confirm that

• If using HA, I have confirmed the internal URL is set correctly
• I have tried a wired connection for issues related to interrupted or poor playback quality
• If the problem relates to a device then I have checked the device settings
• If it is a frontend issue, I have tried a different widely used browser
• For voice problems, I have sought help elsewhere before returning here
• For playback problems, I have recycled power to the physical device

The problem

I initially reported this a few months back which was largely fixed by this commit: music-assistant/server@5a85ce0

I'm still seeing the same behavior (transparent pngs are being loaded as jpgs with back background) on some occasions. I don't know if it's the only way to reproduce / place to observe, but logos loaded from cache in the player pane seem to the easiest way to reproduce this.

Working URL: http://localhost:8095/imageproxy?path=https%253A%252F%252Fsounds.files.bbci.co.uk%252F3.9.4%252Fnetworks%252Fbbc_6music%252Fcolour_450x450.png&provider=bbc_sounds&checksum=&size=256

Incorrect URL: http://localhost:8095/imageproxy?provider=bbc_sounds&size=500&fmt=jpeg&path=https%253A%252F%252Fsounds.files.bbci.co.uk%252F3.9.4%252Fnetworks%252Fbbc_6music%252Fcolour_450x450.png

Example:

This is as of 2.8.0 beta / dev r35662

How to reproduce

1. Load a radio stream with a transparent png icon
2. Reload page
3. Observe cached jpg version

Music Providers

BBC Sounds

Player Providers

N/A - same for all

Full log output

N/A

Additional information

N/A

What version of Home Assistant Core (if used) are your running

N/A

What type of installation are you running?

Home Assistant OS

On what type of hardware are you running?

macOS

Have you included ALL of the information specified in the Troubleshooting FAQ or explained why you cannot

• Yes

[github-actions]

⚠️ Issue Template Validation

Thank you for reporting this issue! However, there are some problems with the issue template:

• No log file appears to be attached. Please attach the full log file.

Please update your issue with the missing information. Providing complete information helps us resolve issues faster. See the Troubleshooting Guide for more details.

[OzGav]

The issue is here https://github.com/music-assistant/server/blob/d2b0d10e2985636cc52635779a47143e1e44072f/music_assistant/models/player.py#L1565

        if active_queue and (current_item := active_queue.current_item):
            item_image_url = (
                # the image format needs to be 500x500 jpeg for maximum compatibility with players
                self.mass.metadata.get_image_url(current_item.image, size=500, image_format="jpeg")
                if current_item.image
                else None
            )

@MarvinSchenkel what do you think about this?

[OzGav]

Maybe bear this in mind when looking at this as well? https://github.com/orgs/music-assistant/discussions/5047

[kieranhogg]

fix.patch

index c11d9268..9451560c 100644
--- a/music_assistant/models/player.py
+++ b/music_assistant/models/player.py
@@ -1563,10 +1562,7 @@ class Player(ABC):
             active_queue = self.mass.player_queues.get(self.player_id)
         if active_queue and (current_item := active_queue.current_item):
             item_image_url = (
-                # the image format needs to be 500x500 jpeg for maximum compatibility with players
-                self.mass.metadata.get_image_url(current_item.image, size=500, image_format="jpeg")
-                if current_item.image
-                else None
+                self.mass.metadata.get_image_url(current_item.image) if current_item.image else None
             )
             if current_item.streamdetails and (
                 stream_metadata := current_item.streamdetails.stream_metadata
@@ -1600,10 +1596,7 @@ class Player(ABC):
                     title=f"{media_item.name} ({version})" if version else media_item.name,
                     artist=getattr(media_item, "artist_str", None),
                     album=album.name if album else podcast.name if podcast else description,
-                    # the image format needs to be 500x500 jpeg for maximum player compatibility
-                    image_url=self.mass.metadata.get_image_url(
-                        current_item.media_item.image, size=500, image_format="jpeg"
-                    )
+                    image_url=self.mass.metadata.get_image_url(current_item.media_item.image)
                     or item_image_url
                     if current_item.media_item.image
                     else item_image_url,

I can confirm the attached patch does resolve the issue, but I'm sure there is a reason it was there in the first place, however.

Ironically, with the metadata being fixed now, the player almost never shows the station logo as it either changes to a programme logo or a track image. So this can definitely wait for a proper solution from the Sounds side, it might be more pressing for other providers.