Skip to content

111#10

Merged
sunjunnan79 merged 10 commits intomuxi-Infra:mainfrom
luohuixi:main
Dec 15, 2025
Merged

111#10
sunjunnan79 merged 10 commits intomuxi-Infra:mainfrom
luohuixi:main

Conversation

@luohuixi
Copy link
Copy Markdown
Contributor

@luohuixi luohuixi commented Dec 8, 2025

No description provided.

r := discovery.NewResolver(client.name, client.discoveryCenter, client.l)
resolver.Register(r)
conn, err := grpc.NewClient(
"muxi:///"+client.name, // 没用上
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

前缀不需要吧,直接让使用方传入就行

namespace: "/services",
logger: logx.NewStdLogger(),
username: "root",
password: "12345678",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

默认值里不要写这种账号密码,没有设置就留空

return err
}

pkg2 := maxFirstLetter(pkg)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没看懂命名

return err
}

pkg2 := maxFirstLetter(pkg)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Comment thread tool/gin/gin.go Outdated

var ginApiCmd = &cobra.Command{
Use: "api",
Short: "给一个api文件的示例, 就不用记住格式了",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

描述专业化一点

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是不是应该叫example之类的比较好?

@sunjunnan79
Copy link
Copy Markdown
Contributor

代码有点多,而且很多动态注入的代码,直接合进去看效果吧

@sunjunnan79 sunjunnan79 merged commit 4112c79 into muxi-Infra:main Dec 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants