restore notebook toolbar under jlab4 - fix for issue #1107#1109
Merged
Conversation
indeed with jlab4 we need to duplicate the code that creates the notebook toolbar this version is much nicer already, but still builds an incomplete toolbar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a fix for solving issue #1107
here's what both widgets (Notebook and Jupytext Notebook) look like
as can be seen on the screenshot there remains issues related to extensions
here I have installed
jupyterlab-courselevelsthat adds some buttons in the toolbar; and what happens is that these buttons show up in the pure Notebook (ipynb) widget but not in the Jupytext Notebook widgetIMO this PR is still very welcome because
So @mwouts I would be grateful if you could publish this under pypi - it is already versioned as 1.15.0.dev2