feat: support ESLint 8.x#14
Draft
MichaelDeBoey wants to merge 2 commits intomysticatea:masterfrom
Draft
Conversation
7b0d6a0 to
ccd7702
Compare
Author
|
Tests are failing > eslint4b@8.0.0-beta.0 pretest
> node scripts/build
[20:56:06] Remove 'dist'.
[20:56:06] Update 'scripts/shim/core-rules.js'.
[20:56:06] Parse the source files.
'eslint' is imported by scripts/shim/linter.js, but could not be resolved – treating it as an external dependency
'eslint' is imported by scripts/shim/index.js, but could not be resolved – treating it as an external dependency
[20:56:06] Generate file contents.
Entry module "scripts/shim/linter.js" is implicitly using "default" export mode, which means for CommonJS output that its default export is assigned to "module.exports". For many tools, such CommonJS output will not be interchangeable with the original ES module. If this is intended, explicitly set "output.exports" to either "auto" or "default", otherwise you might want to consider changing the signature of "scripts/shim/linter.js" to use named exports only.
Entry module "scripts/shim/core-rules.js" is implicitly using "default" export mode, which means for CommonJS output that its default export is assigned to "module.exports". For many tools, such CommonJS output will not be interchangeable with the original ES module. If this is intended, explicitly set "output.exports" to either "auto" or "default", otherwise you might want to consider changing the signature of "scripts/shim/core-rules.js" to use named exports only.
Entry module "scripts/shim/index.js" is implicitly using "default" export mode, which means for CommonJS output that its default export is assigned to "module.exports". For many tools, such CommonJS output will not be interchangeable with the original ES module. If this is intended, explicitly set "output.exports" to either "auto" or "default", otherwise you might want to consider changing the signature of "scripts/shim/index.js" to use named exports only.
[20:56:06] Minify file contents.
[20:56:06] - linter.js
[20:56:06] - core-rules.js
[20:56:07] - index.js
[20:56:07] Check version.
[20:56:07] Up to date: 8.0.0-beta.0
[20:56:07] Completed!
> eslint4b@8.0.0-beta.0 test
> npm run -s lint && karma start --single-run
Oops! Something went wrong! :(
ESLint: 8.0.0-beta.0
Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Failed to load plugin '@mysticatea' declared in '.eslintrc.yml': Package subpath './lib/rules/array-bracket-spacing' is not defined by "exports" in .../eslint4b/node_modules/eslint/package.json
Referenced from: .../eslint4b/.eslintrc.yml
at new NodeError (node:internal/errors:370:5)
at throwExportsNotFound (node:internal/modules/esm/resolve:335:9)
at packageExportsResolve (node:internal/modules/esm/resolve:560:3)
at resolveExports (node:internal/modules/cjs/loader:476:36)
at Function.Module._findPath (node:internal/modules/cjs/loader:516:31)
at Function.Module._resolveFilename (node:internal/modules/cjs/loader:913:27)
at Function.Module._load (node:internal/modules/cjs/loader:772:27)
at Module.require (node:internal/modules/cjs/loader:999:19)
at require (.../eslint4b/node_modules/v8-compile-cache/v8-compile-cache.js:159:20)
at Object.<anonymous> (.../eslint4b/node_modules/eslint-plugin-vue/lib/rules/array-bracket-spacing.js:10:3)This will be fixed by merging mysticatea/eslint-plugin#29, as that loosens the version of |
7 tasks
16 tasks
ccd7702 to
b413beb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESLint v8.0.0 is released 🎉
devDependency compatibility with ESLint 8:
@mysticatea/eslint-plugin(Support ESLint 8.x eslint-plugin#31)Closes #13